Skip to content

Rollup of 3 pull requests #149247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 24, 2025
Merged

Rollup of 3 pull requests #149247

merged 6 commits into from
Nov 24, 2025
+157 −2

Conversation

@jhpratt
Copy link
Member

@jhpratt jhpratt commented Nov 23, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzy and others added 6 commits November 21, 2025 23:03
@reddevilmidzy
Add regression test for 128705
a4ee7f8
@madsmtm
Add doc aliases list and vector to Vec
1111730
@lolbinarycat
validate usage of crate-level doc attributes
2ee6196
@jhpratt
Rollup merge of rust-lang#149179 - reddevilmidzy:test, r=JonathanBrouwer
2b3b95b 
Add regression test for 128705

close: rust-lang#128705
@jhpratt
Rollup merge of rust-lang#149197 - lolbinarycat:rustdoc-bad-render-at…
fdcf1f2 
…tr, r=GuillaumeGomez

validate usage of crate-level doc attributes

fixes rust-lang#149187

r? `@GuillaumeGomez`
@jhpratt
Rollup merge of rust-lang#149232 - madsmtm:vec-doc-aliases, r=Noratrieb
b758cbd 
Add doc aliases "vector" and "list" to `Vec`

- "vector" is what "vec" is short form for.
- "list" is a common name for this concept in a lot of other languages (`ArrayList` in Java, `list` in Python, `List` in C#). C++ uses the term for a linked list (`std::list`), so maybe this is contentious?

I believe that this falls under [the doc alias policy](https://std-dev-guide.rust-lang.org/policy/doc-alias.html), and I think it's plausible that a newcomer would search for either of these terms, and expect to find `Vec`.

r? libs
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 23, 2025
@jhpratt
Copy link
Member Author

jhpratt commented Nov 23, 2025

@bors r+ rollup=never p=3

@bors
Copy link
Collaborator

bors commented Nov 23, 2025

📌 Commit b758cbd has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2025
@bors
Copy link
Collaborator

bors commented Nov 23, 2025

⌛ Testing commit b758cbd with merge d3e1ccd...

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing d3e1ccd to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2025
@bors bors merged commit d3e1ccd into rust-lang:main Nov 24, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 24, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 24, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#149179 Add regression test for 128705 4f81c50ffdf76566a8049ce2376a3fb43c29783f (link)
#149197 validate usage of crate-level doc attributes 6da9d23a886aeb21d99cdcb6d2dac16567e1d58d (link)
#149232 Add doc aliases "vector" and "list" to Vec 1646f5d7d11373f20ea20a6b16de0af9f04def68 (link)

previous master: c23ed3ef28

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c23ed3e (parent) -> d3e1ccd (this PR)

Test differences

Show 939 test diffs

Stage 0

  • errors::verify_passes_abi_ne_90: pass -> [missing] (J0)
  • errors::verify_passes_attr_application_struct_105: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_struct_union_104: pass -> [missing] (J0)
  • errors::verify_passes_attr_application_struct_union_106: [missing] -> pass (J0)
  • errors::verify_passes_cannot_stabilize_deprecated_109: pass -> [missing] (J0)
  • errors::verify_passes_deprecated_attribute_107: pass -> [missing] (J0)
  • errors::verify_passes_doc_alias_bad_char_15: pass -> [missing] (J0)
  • errors::verify_passes_doc_alias_bad_location_19: [missing] -> pass (J0)
  • errors::verify_passes_doc_alias_empty_14: pass -> [missing] (J0)
  • errors::verify_passes_doc_alias_malformed_21: pass -> [missing] (J0)
  • errors::verify_passes_doc_alias_malformed_23: [missing] -> pass (J0)
  • errors::verify_passes_doc_attr_expects_string_3: [missing] -> pass (J0)
  • errors::verify_passes_doc_attr_not_crate_level_33: pass -> [missing] (J0)
  • errors::verify_passes_doc_auto_cfg_expects_hide_or_show_40: [missing] -> pass (J0)
  • errors::verify_passes_doc_auto_cfg_hide_show_expects_list_41: [missing] -> pass (J0)
  • errors::verify_passes_doc_fake_variadic_not_valid_26: pass -> [missing] (J0)
  • errors::verify_passes_doc_inline_conflict_29: pass -> [missing] (J0)
  • errors::verify_passes_doc_keyword_only_impl_27: pass -> [missing] (J0)
  • errors::verify_passes_doc_test_unknown_36: [missing] -> pass (J0)
  • errors::verify_passes_doc_test_unknown_include_45: pass -> [missing] (J0)
  • errors::verify_passes_duplicate_feature_err_117: pass -> [missing] (J0)
  • errors::verify_passes_extern_main_96: pass -> [missing] (J0)
  • errors::verify_passes_extern_main_98: [missing] -> pass (J0)
  • errors::verify_passes_feature_previously_declared_94: pass -> [missing] (J0)
  • errors::verify_passes_has_incoherent_inherent_impl_47: pass -> [missing] (J0)
  • errors::verify_passes_inner_crate_level_attr_7: pass -> [missing] (J0)
  • errors::verify_passes_lang_item_fn_with_target_feature_79: pass -> [missing] (J0)
  • errors::verify_passes_layout_align_86: [missing] -> pass (J0)
  • errors::verify_passes_layout_homogeneous_aggregate_86: pass -> [missing] (J0)
  • errors::verify_passes_layout_size_85: pass -> [missing] (J0)
  • errors::verify_passes_layout_size_87: [missing] -> pass (J0)
  • errors::verify_passes_loop_match_attr_4: pass -> [missing] (J0)
  • errors::verify_passes_loop_match_attr_6: [missing] -> pass (J0)
  • errors::verify_passes_macro_only_attribute_60: pass -> [missing] (J0)
  • errors::verify_passes_macro_only_attribute_62: [missing] -> pass (J0)
  • errors::verify_passes_missing_lang_item_77: pass -> [missing] (J0)
  • errors::verify_passes_multiple_rustc_main_97: [missing] -> pass (J0)
  • errors::verify_passes_non_exported_macro_invalid_attrs_66: pass -> [missing] (J0)
  • errors::verify_passes_proc_macro_bad_sig_122: [missing] -> pass (J0)
  • errors::verify_passes_repr_align_greater_than_target_max_60: [missing] -> pass (J0)
  • errors::verify_passes_rustc_force_inline_coro_64: pass -> [missing] (J0)
  • errors::verify_passes_rustc_legacy_const_generics_only_54: [missing] -> pass (J0)
  • errors::verify_passes_rustc_lint_opt_deny_field_access_71: pass -> [missing] (J0)
  • errors::verify_passes_rustc_lint_opt_ty_72: [missing] -> pass (J0)
  • errors::verify_passes_should_be_applied_to_static_12: pass -> [missing] (J0)
  • errors::verify_passes_trait_impl_const_stable_113: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_fn_abi_131: [missing] -> pass (J0)
  • errors::verify_passes_unused_duplicate_68: pass -> [missing] (J0)
  • errors::verify_passes_unused_duplicate_70: [missing] -> pass (J0)
  • errors::verify_passes_useless_assignment_101: [missing] -> pass (J0)
  • errors::verify_passes_useless_assignment_99: pass -> [missing] (J0)

Stage 1

  • errors::verify_passes_attr_application_enum_104: [missing] -> pass (J1)
  • errors::verify_passes_attr_application_struct_103: pass -> [missing] (J1)
  • errors::verify_passes_attr_application_struct_enum_union_105: pass -> [missing] (J1)
  • errors::verify_passes_autodiff_attr_5: [missing] -> pass (J1)
  • errors::verify_passes_const_stable_not_stable_121: [missing] -> pass (J1)
  • errors::verify_passes_deprecated_annotation_has_no_effect_75: [missing] -> pass (J1)
  • errors::verify_passes_doc_alias_duplicated_19: pass -> [missing] (J1)
  • errors::verify_passes_doc_attr_expects_no_value_4: [missing] -> pass (J1)
  • errors::verify_passes_doc_attr_expects_string_3: [missing] -> pass (J1)
  • errors::verify_passes_doc_attr_not_crate_level_35: [missing] -> pass (J1)
  • errors::verify_passes_doc_auto_cfg_expects_hide_or_show_38: pass -> [missing] (J1)
  • errors::verify_passes_doc_auto_cfg_hide_show_expects_list_39: pass -> [missing] (J1)
  • errors::verify_passes_doc_expect_str_13: pass -> [missing] (J1)
  • errors::verify_passes_doc_fake_variadic_not_valid_26: pass -> [missing] (J1)
  • errors::verify_passes_doc_fake_variadic_not_valid_28: [missing] -> pass (J1)
  • errors::verify_passes_doc_inline_conflict_29: pass -> [missing] (J1)
  • errors::verify_passes_doc_inline_only_use_30: pass -> [missing] (J1)
  • errors::verify_passes_doc_keyword_not_keyword_25: [missing] -> pass (J1)
  • errors::verify_passes_doc_keyword_only_impl_29: [missing] -> pass (J1)
  • errors::verify_passes_doc_masked_only_extern_crate_31: pass -> [missing] (J1)
  • errors::verify_passes_doc_search_unbox_invalid_28: pass -> [missing] (J1)
  • errors::verify_passes_doc_search_unbox_invalid_30: [missing] -> pass (J1)
  • errors::verify_passes_doc_test_literal_37: [missing] -> pass (J1)
  • errors::verify_passes_duplicate_feature_err_119: [missing] -> pass (J1)
  • errors::verify_passes_extern_main_96: pass -> [missing] (J1)
  • errors::verify_passes_ignored_attr_with_macro_10: [missing] -> pass (J1)
  • errors::verify_passes_implied_feature_not_exist_116: pass -> [missing] (J1)
  • errors::verify_passes_ineffective_unstable_impl_123: pass -> [missing] (J1)
  • errors::verify_passes_inline_ignored_for_exported_100: pass -> [missing] (J1)
  • errors::verify_passes_layout_homogeneous_aggregate_86: pass -> [missing] (J1)
  • errors::verify_passes_link_52: [missing] -> pass (J1)
  • errors::verify_passes_may_dangle_69: [missing] -> pass (J1)
  • errors::verify_passes_mixed_export_name_and_no_mangle_6: pass -> [missing] (J1)
  • errors::verify_passes_no_link_53: [missing] -> pass (J1)
  • errors::verify_passes_non_exported_macro_invalid_attrs_66: pass -> [missing] (J1)
  • errors::verify_passes_object_lifetime_err_101: pass -> [missing] (J1)
  • errors::verify_passes_rustc_allow_const_fn_unstable_62: pass -> [missing] (J1)
  • errors::verify_passes_rustc_const_stable_indirect_pairing_125: pass -> [missing] (J1)
  • errors::verify_passes_rustc_dirty_clean_56: pass -> [missing] (J1)
  • errors::verify_passes_rustc_lint_opt_deny_field_access_73: [missing] -> pass (J1)
  • errors::verify_passes_rustc_lint_opt_ty_70: pass -> [missing] (J1)
  • errors::verify_passes_rustc_pub_transparent_65: [missing] -> pass (J1)
  • errors::verify_passes_should_be_applied_to_fn_11: [missing] -> pass (J1)
  • errors::verify_passes_trait_impl_const_stable_113: pass -> [missing] (J1)
  • errors::verify_passes_unexportable_item_129: [missing] -> pass (J1)
  • errors::verify_passes_unexportable_type_in_interface_131: pass -> [missing] (J1)
  • errors::verify_passes_unexportable_type_repr_132: [missing] -> pass (J1)
  • errors::verify_passes_unrecognized_argument_92: pass -> [missing] (J1)
  • errors::verify_passes_unstable_attr_for_already_stable_feature_112: [missing] -> pass (J1)

(and 444 additional test diffs)

Additionally, 395 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d3e1ccdf40ae7b7a6dc81edc073d80dad7b66f75 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1683.9s -> 1902.4s (+13.0%)
  2. dist-apple-various: 3565.5s -> 4006.3s (+12.4%)
  3. x86_64-gnu-nopt: 6603.6s -> 7357.9s (+11.4%)
  4. dist-x86_64-solaris: 5505.4s -> 4922.1s (-10.6%)
  5. aarch64-apple: 8130.1s -> 8990.9s (+10.6%)
  6. dist-aarch64-apple: 6665.7s -> 7352.3s (+10.3%)
  7. dist-aarch64-msvc: 5734.3s -> 6219.4s (+8.5%)
  8. aarch64-msvc-2: 4886.9s -> 5275.1s (+7.9%)
  9. test-various: 6576.3s -> 6087.5s (-7.4%)
  10. x86_64-msvc-ext2: 5644.5s -> 6020.5s (+6.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@jhpratt jhpratt deleted the rollup-mq8f5wo branch November 24, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt @bors @rust-timer @rustbot @reddevilmidzy @madsmtm @lolbinarycat